From f298891572d5900ca1dbeddf3f100d9043eb77ee Mon Sep 17 00:00:00 2001
From: Carl Tibule <cjtibule@pm.me>
Date: Thu, 23 Feb 2023 00:06:24 -0600
Subject: [PATCH] Modified register user service method to be async

---
 YABA.API/Controllers/UsersController.cs           | 4 ++--
 YABA.API/Middlewares/AddCustomClaimsMiddleware.cs | 2 --
 YABA.Service/Interfaces/IUserService.cs           | 9 +++++----
 YABA.Service/UserService.cs                       | 5 +++--
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/YABA.API/Controllers/UsersController.cs b/YABA.API/Controllers/UsersController.cs
index 0829682..2161c3b 100644
--- a/YABA.API/Controllers/UsersController.cs
+++ b/YABA.API/Controllers/UsersController.cs
@@ -27,7 +27,7 @@ namespace YABA.API.Controllers
         [ProducesResponseType(typeof(UserResponse), (int)HttpStatusCode.OK)]
         [ProducesResponseType((int)HttpStatusCode.NotFound)]
         [ProducesResponseType((int)HttpStatusCode.NoContent)]
-        public IActionResult Register()
+        public async Task<IActionResult> Register()
         {
             var authProviderId = this.GetAuthProviderId();
 
@@ -37,7 +37,7 @@ namespace YABA.API.Controllers
 
             if (isRegistered) return NoContent();
 
-            var registedUser = _userService.RegisterUser(authProviderId);
+            var registedUser = await _userService.RegisterUser(authProviderId);
             return Ok(_mapper.Map<UserResponse>(registedUser));
         }
     }
diff --git a/YABA.API/Middlewares/AddCustomClaimsMiddleware.cs b/YABA.API/Middlewares/AddCustomClaimsMiddleware.cs
index f837fdc..db3893f 100644
--- a/YABA.API/Middlewares/AddCustomClaimsMiddleware.cs
+++ b/YABA.API/Middlewares/AddCustomClaimsMiddleware.cs
@@ -19,8 +19,6 @@ namespace YABA.API.Middlewares
         {
             if (httpContext.User != null && httpContext.User.Identity.IsAuthenticated)
             {
-                var claims = new List<Claim>();
-
                 var userAuthProviderId = httpContext.User.Identity.GetAuthProviderId();
 
                 if (!string.IsNullOrEmpty(userAuthProviderId))
diff --git a/YABA.Service/Interfaces/IUserService.cs b/YABA.Service/Interfaces/IUserService.cs
index 6764766..95e3c45 100644
--- a/YABA.Service/Interfaces/IUserService.cs
+++ b/YABA.Service/Interfaces/IUserService.cs
@@ -1,11 +1,12 @@
-using YABA.Common.DTOs;
+using System.Threading.Tasks;
+using YABA.Common.DTOs;
 
 namespace YABA.Service.Interfaces
 {
     public interface IUserService
     {
-        public bool IsUserRegistered(string authProviderId);
-        public UserDTO RegisterUser(string authProviderId);
-        public int GetUserId(string authProviderId);
+        bool IsUserRegistered(string authProviderId);
+        Task<UserDTO> RegisterUser(string authProviderId);
+        int GetUserId(string authProviderId);
     }
 }
diff --git a/YABA.Service/UserService.cs b/YABA.Service/UserService.cs
index 3269525..534cd52 100644
--- a/YABA.Service/UserService.cs
+++ b/YABA.Service/UserService.cs
@@ -1,5 +1,6 @@
 using AutoMapper;
 using System.Linq;
+using System.Threading.Tasks;
 using YABA.Common.DTOs;
 using YABA.Data.Context;
 using YABA.Models;
@@ -25,7 +26,7 @@ namespace YABA.Service
             return _roContext.Users.Any(x => x.Auth0Id == authProviderId);
         }
 
-        public UserDTO RegisterUser(string authProviderId)
+        public async Task<UserDTO> RegisterUser(string authProviderId)
         {
             if(IsUserRegistered(authProviderId))
             {
@@ -39,7 +40,7 @@ namespace YABA.Service
             };
 
             var registedUser = _context.Users.Add(userToRegister);
-            return _context.SaveChanges() > 0 ? _mapper.Map<UserDTO>(registedUser.Entity) : null;
+            return await _context.SaveChangesAsync() > 0 ? _mapper.Map<UserDTO>(registedUser.Entity) : null;
         }
 
         public int GetUserId(string authProviderId)