cjtibule/YABA
1
0
Fork 0
Code Issues 10 Pull Requests Packages Projects 1 Releases Wiki Activity

Modified register user service method to be async #16

Merged
carltibule merged 1 commits from feature/RegisterNewUsersLocally into develop 2023-02-23 00:09:49 -06:00
Conversation 0 Commits 1 Files Changed 4 +10 -10
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
YABA.API/Controllers/UsersController.cs
View File

@ -27,7 +27,7 @@ namespace YABA.API.Controllers
[ProducesResponseType(typeof(UserResponse), (int)HttpStatusCode.OK)] [ProducesResponseType(typeof(UserResponse), (int)HttpStatusCode.OK)]
[ProducesResponseType((int)HttpStatusCode.NotFound)] [ProducesResponseType((int)HttpStatusCode.NotFound)]
[ProducesResponseType((int)HttpStatusCode.NoContent)] [ProducesResponseType((int)HttpStatusCode.NoContent)]
public IActionResult Register() public async Task<IActionResult> Register()
{ {
var authProviderId = this.GetAuthProviderId(); var authProviderId = this.GetAuthProviderId();
@ -37,7 +37,7 @@ namespace YABA.API.Controllers
if (isRegistered) return NoContent(); if (isRegistered) return NoContent();
var registedUser = _userService.RegisterUser(authProviderId); var registedUser = await _userService.RegisterUser(authProviderId);
return Ok(_mapper.Map<UserResponse>(registedUser)); return Ok(_mapper.Map<UserResponse>(registedUser));
} }
} }

2
YABA.API/Middlewares/AddCustomClaimsMiddleware.cs
View File

@ -19,8 +19,6 @@ namespace YABA.API.Middlewares
{ {
if (httpContext.User != null && httpContext.User.Identity.IsAuthenticated) if (httpContext.User != null && httpContext.User.Identity.IsAuthenticated)
{ {
var claims = new List<Claim>();
var userAuthProviderId = httpContext.User.Identity.GetAuthProviderId(); var userAuthProviderId = httpContext.User.Identity.GetAuthProviderId();
if (!string.IsNullOrEmpty(userAuthProviderId)) if (!string.IsNullOrEmpty(userAuthProviderId))

9
YABA.Service/Interfaces/IUserService.cs
View File

@ -1,11 +1,12 @@
using YABA.Common.DTOs; using System.Threading.Tasks;
using YABA.Common.DTOs;
namespace YABA.Service.Interfaces namespace YABA.Service.Interfaces
{ {
public interface IUserService public interface IUserService
{ {
public bool IsUserRegistered(string authProviderId); bool IsUserRegistered(string authProviderId);
public UserDTO RegisterUser(string authProviderId); Task<UserDTO> RegisterUser(string authProviderId);
public int GetUserId(string authProviderId); int GetUserId(string authProviderId);
} }
} }

5
YABA.Service/UserService.cs
View File

@ -1,5 +1,6 @@
using AutoMapper; using AutoMapper;
using System.Linq; using System.Linq;
using System.Threading.Tasks;
using YABA.Common.DTOs; using YABA.Common.DTOs;
using YABA.Data.Context; using YABA.Data.Context;
using YABA.Models; using YABA.Models;
@ -25,7 +26,7 @@ namespace YABA.Service
return _roContext.Users.Any(x => x.Auth0Id == authProviderId); return _roContext.Users.Any(x => x.Auth0Id == authProviderId);
} }
public UserDTO RegisterUser(string authProviderId) public async Task<UserDTO> RegisterUser(string authProviderId)
{ {
if(IsUserRegistered(authProviderId)) if(IsUserRegistered(authProviderId))
{ {
@ -39,7 +40,7 @@ namespace YABA.Service
}; };
var registedUser = _context.Users.Add(userToRegister); var registedUser = _context.Users.Add(userToRegister);
return _context.SaveChanges() > 0 ? _mapper.Map<UserDTO>(registedUser.Entity) : null; return await _context.SaveChangesAsync() > 0 ? _mapper.Map<UserDTO>(registedUser.Entity) : null;
} }
public int GetUserId(string authProviderId) public int GetUserId(string authProviderId)